Skip to content
Snippets Groups Projects
Commit 6a5eacde authored by BENOIT JEAN's avatar BENOIT JEAN
Browse files

fix value name and clarify messages

parent 56dea1bc
No related merge requests found
...@@ -123,19 +123,19 @@ class NameZoneValidator(CustomValidator): ...@@ -123,19 +123,19 @@ class NameZoneValidator(CustomValidator):
def validate(self, ipaddress, request): def validate(self, ipaddress, request):
dns_name = ipaddress.dns_name dns_name = ipaddress.dns_name
#breakpoint()
if dns_name == "": if dns_name == "":
self.fail("DNS name can not be empty", field="dns_name") self.fail("DNS name can not be empty", field="dns_name")
if dns_name.find(".") == -1: if dns_name.find(".") == -1:
self.fail("DNS name must contain a zone", field="dns_name") self.fail("DNS name must contain a zone", field="dns_name")
# This check is necessary because of the prefix-DNS view relation of dns_sync
if not ipaddress_in_existing_prefix(ipaddress, request): if not ipaddress_in_existing_prefix(ipaddress, request):
self.fail(f"IP address '{address}' is not in any existing prefix") self.fail(f"IP address '{ipaddress}' is not in any existing prefix", field="address")
if not prefix_has_dns_view(ipaddress, request): if not prefix_has_dns_view(ipaddress, request):
self.fail(f"IP address '{address}' is in a prefix for which there is no DNS view defined. Ask NetBox administrator") self.fail(f"IP address '{ipaddress}' is in a prefix for which there is no DNS view defined. Ask your NetBox administrator", field="address")
if not name_has_valid_zone(dns_name, ipaddress, request): if not name_has_valid_zone(dns_name, ipaddress, request):
self.fail(f"Name '{dns_name}' has an invalid zone name", field="dns_name") self.fail(f"Name '{dns_name}' is in an non-existing zone name", field="dns_name")
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment