From 6a5eacdef2e23f156f8fc4c5d38af62e669b381f Mon Sep 17 00:00:00 2001
From: Jean Benoit <jean@unistra.fr>
Date: Sun, 9 Mar 2025 19:15:45 +0000
Subject: [PATCH] fix value name and clarify messages
---
dnssync_perm.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/dnssync_perm.py b/dnssync_perm.py
index c1a393f..a759220 100644
--- a/dnssync_perm.py
+++ b/dnssync_perm.py
@@ -123,19 +123,19 @@ class NameZoneValidator(CustomValidator):
def validate(self, ipaddress, request):
dns_name = ipaddress.dns_name
- #breakpoint()
if dns_name == "":
self.fail("DNS name can not be empty", field="dns_name")
if dns_name.find(".") == -1:
self.fail("DNS name must contain a zone", field="dns_name")
+ # This check is necessary because of the prefix-DNS view relation of dns_sync
if not ipaddress_in_existing_prefix(ipaddress, request):
- self.fail(f"IP address '{address}' is not in any existing prefix")
+ self.fail(f"IP address '{ipaddress}' is not in any existing prefix", field="address")
if not prefix_has_dns_view(ipaddress, request):
- self.fail(f"IP address '{address}' is in a prefix for which there is no DNS view defined. Ask NetBox administrator")
+ self.fail(f"IP address '{ipaddress}' is in a prefix for which there is no DNS view defined. Ask your NetBox administrator", field="address")
if not name_has_valid_zone(dns_name, ipaddress, request):
- self.fail(f"Name '{dns_name}' has an invalid zone name", field="dns_name")
+ self.fail(f"Name '{dns_name}' is in an non-existing zone name", field="dns_name")
--
GitLab