Skip to content

refactor: extraction logique de duel, validation DTOs, repository, configuration dynamique et documentation

LI HAOXUAN requested to merge haoxuan.li/2025:refactor/grimoire-club into main
  • Extracted duel logic to DuelEngine (strategy pattern)
  • Added validation methods to DTOs (AddMemberDto, DuelRequestDto)
  • Centralized exception handling in App.java
  • Introduced repository layer (SorcererRepository, WizardClubRepository)
  • Updated service and controller to use Optional for fetch methods
  • Loaded spell power config from application.properties via Values
  • Improved and expanded test coverage
  • Enhanced API documentation (OpenAPI, README)
  • Added JavaDoc and improved naming consistency
  • Updated ADRs to document architectural decisions

BREAKING CHANGE: This refactoring changes core service, controller, and DTO APIs. Please review usage and integration points.

Merge request reports