Skip to content
Snippets Groups Projects
Verified Commit 31a11bb6 authored by Daniel Bessey's avatar Daniel Bessey
Browse files

Don't include items in public list of sets

parent 81358d50
Branches
Tags
No related merge requests found
Pipeline #303102 passed with stage
in 4 minutes and 36 seconds
......@@ -174,15 +174,9 @@ class PublicItemListSerializer(PublicItemSerializer):
]
class PublicNestedItemSerializer(PublicItemSerializer):
class Meta(PublicItemSerializer.Meta):
fields = ["id", "title"]
class PublicSetSerializer(ThumbnailUrlMixin, serializers.ModelSerializer):
project = NestedProjectSerializer()
creator = NestedUserSerializer()
items = serializers.SerializerMethodField()
thumbnails = serializers.SerializerMethodField()
class Meta:
......@@ -193,19 +187,12 @@ class PublicSetSerializer(ThumbnailUrlMixin, serializers.ModelSerializer):
"description",
"publisher",
"project",
"items",
"creator",
"created_at",
"updated_at",
"thumbnails",
]
@extend_schema_field(PublicNestedItemSerializer)
def get_items(self, instance: Set):
items = instance.public_items()
serializer = PublicNestedItemSerializer(items, many=True)
return serializer.data
class PublicTemplateSerializer(serializers.ModelSerializer):
fields = serializers.SerializerMethodField(method_name="get_metadata_fields")
......
......@@ -45,11 +45,6 @@ class SetTest(SetUpMixin, APITestCase):
["count", "next_page", "previous_page", "results"],
)
def test_set_detail_contains_list_of_items(self):
response = self.client.get(reverse("public:set-detail", kwargs={"pk": self.public_set1.id}))
self.assertEqual(response.status_code, status.HTTP_200_OK)
self.assertEqual(len(response.data["items"]), 5)
def test_post_method_not_allowed(self):
response = self.client.post(reverse("public:set-list"), {})
self.assertEqual(response.status_code, status.HTTP_405_METHOD_NOT_ALLOWED)
......@@ -78,8 +73,3 @@ class SetTest(SetUpMixin, APITestCase):
response = self.client.get(reverse("public:set-list"))
self.assertEqual(len(response.data["results"]), 2)
self.assertNotIn(self.deleted_set.id, [_["id"] for _ in response.data["results"]])
def test_deleted_item_is_not_included_in_set_items(self):
response = self.client.get(reverse("public:set-detail", kwargs={"pk": self.public_set1.id}))
self.assertEqual(len(response.data["items"]), 5)
self.assertNotIn(self.deleted_item.id, [_["id"] for _ in response.data["items"]])
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment